<html>
<head><meta charset="utf-8"><title>Hashing of attributes side table · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Hashing.20of.20attributes.20side.20table.html">Hashing of attributes side table</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="233217804"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Hashing%20of%20attributes%20side%20table/near/233217804" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Hashing.20of.20attributes.20side.20table.html#233217804">(Apr 05 2021 at 19:29)</a>:</h4>
<p><span class="user-mention" data-user-id="248906">@cjgillot</span> In <a href="https://github.com/rust-lang/rust/pull/79519">https://github.com/rust-lang/rust/pull/79519</a>, where did you ensure that attributes end up in the crate hash?</p>



<a name="233217965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Hashing%20of%20attributes%20side%20table/near/233217965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Hashing.20of.20attributes.20side.20table.html#233217965">(Apr 05 2021 at 19:30)</a>:</h4>
<p>Since the attributes are stored in a side table, <code>finalize_and_compute_crate_hash</code> will no longer hash attributes when it hashes bodies</p>



<a name="233219470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Hashing%20of%20attributes%20side%20table/near/233219470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cjgillot <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Hashing.20of.20attributes.20side.20table.html#233219470">(Apr 05 2021 at 19:43)</a>:</h4>
<p>Sorry, I forgot to hash them. Making a PR.</p>



<a name="233219586"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Hashing%20of%20attributes%20side%20table/near/233219586" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Hashing.20of.20attributes.20side.20table.html#233219586">(Apr 05 2021 at 19:44)</a>:</h4>
<p>thanks</p>



<a name="233219626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Hashing%20of%20attributes%20side%20table/near/233219626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Hill <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Hashing.20of.20attributes.20side.20table.html#233219626">(Apr 05 2021 at 19:44)</a>:</h4>
<p>Someone opened an issue that seemed to be caused by this, though I've been unable to build a minimal reproducer from scratch</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>